Bug #11415
Fix for exported resources with async storeconfigs
| Status: | In Topic Branch Pending Review | Start date: | 12/15/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Daniel Pittman |
% Done: | 0% |
|
| Category: | stored configuration | |||
| Target version: | - | |||
| Affected Puppet version: | Branch: | https://github.com/puppetlabs/puppet/pull/276 | ||
| Keywords: | exported resources, async_storecofigs | |||
| Votes: | 1 |
Description
Hey, I have a problem with the following configuration:
thin_storeconfigs = true async_storeconfigs = true
For example, when I tried to export nagios_host, puppetmaster lost host_name variable during pson export to stomp queue. Host_name variable is used as “namevar” for nagios_host resource and ignored during pson / json export. The patch removes “namevar” check during the export and fixes the problem.
Pull request: https://github.com/puppetlabs/puppet/pull/276
History
Updated by Daniel Pittman 5 months ago
- Status changed from Unreviewed to Investigating
- Assignee set to Daniel Pittman
Hey. Thanks for that – given that PSON transport of these is a fairly low level, and pervasive, part of the system I am going though and doing due diligence to make sure it won’t break anything, and that I understand why we do this the way we do.
The code itself looks fine, and thanks for submitting the test.
One last question: have you signed a CLA with us? It looks like you have not, and we would need one for this change.
Updated by Alexey Lapitsky 5 months ago
Hey, I just signed and sent a copy of the CLA. Let me know if you need anything else.
Daniel Pittman wrote:
Hey. Thanks for that – given that PSON transport of these is a fairly low level, and pervasive, part of the system I am going though and doing due diligence to make sure it won’t break anything, and that I understand why we do this the way we do.
The code itself looks fine, and thanks for submitting the test.
One last question: have you signed a CLA with us? It looks like you have not, and we would need one for this change.
Updated by Oliver Hookins 4 months ago
- Status changed from Investigating to In Topic Branch Pending Review
- Branch set to https://github.com/puppetlabs/puppet/pull/276
Updated by konrad rzentarzewski 2 months ago
with 2.7.9 and async_storeconfigs + thin_storeconfigs i observe all resources (not only exported) are pushed to MQ and DB. is it related?
Updated by Alexey Lapitsky 2 months ago
Hey,
This is not related, my patch fixes only namevar export problem.
konrad rzentarzewski wrote:
with 2.7.9 and async_storeconfigs + thin_storeconfigs i observe all resources (not only exported) are pushed to MQ and DB. is it related?
Updated by konrad rzentarzewski 2 months ago
should we extend this bug, then? thin_storeconfigs are meant for that, thus either there should be actual filtering logic or option should conflict with async_storeconfigs. what do you think?
Updated by Alexey Lapitsky 2 months ago
Well, the problem you have is on the higher level and unrelated to this ticket. My patch fixes “to_pson_data_hash” method of the resource, and this function is called when decision about exporting the resource has already been made.
konrad rzentarzewski wrote:
should we extend this bug, then? thin_storeconfigs are meant for that, thus either there should be actual filtering logic or option should conflict with async_storeconfigs. what do you think?
Updated by konrad rzentarzewski 2 months ago
i’ve created new issue for it: #13128