Bug #1125

incorrect parsing of range after DST change

Added by Jeff Lawhorn almost 4 years ago. Updated 11 months ago.

Status:Accepted Start date:
Priority:Low Due date:
Assignee:- % Done:

0%
Category:schedule
Target version:-
Affected Puppet version:0.24.7 Branch:
Keywords:
Votes: 1

Description

After the Daylight Savings Time change this morning, range statements are not being parsed correctly.

The code:

schedule { 'daily2am':
    range => "02:00 - 02:59",
    period => daily,
    repeat => 1,
}

Worked just fine for the last few months. After the DST change, this error is generated:

err: Could not apply complete catalog: Incorrectly converted time: Sun Mar 09 03:00:23 -0700 2008: 3 vs 2 at /etc/puppet/manifests/schedules/daily2am.pp:6

This happens with versions 0.23.2 and 0.24.2

History

#1
Updated by Jeff Lawhorn almost 4 years ago

The problem appears to have gone away on it’s own at midnight.

So from March 9, 2008 00:00 to March 9, 2008 23:59, the error was generated.

#2
Updated by Luke Kanies almost 4 years ago

  • Status changed from 1 to Closed
  • 7 set to wontfix

If someone would like to fix this, please go for it, but as it is, I’m not going to take up something that won’t show up for another four years.

#3
Updated by Jeff Lawhorn almost 4 years ago

Ummm… Daylight Savings Time change happens twice per year, not once every 4 years.

In a quick look at the code I don’t see what could be causing it, but I’m only just starting to learn Ruby.

#4
Updated by Luke Kanies almost 4 years ago

  • Status changed from Closed to 4
  • 7 deleted (wontfix)

Duh, you’re right, sorry.

#5
Updated by Redmine Admin over 3 years ago

  • Status changed from 4 to Accepted

#6
Updated by Jeff Lawhorn almost 3 years ago

  • Affected Puppet version set to 0.24.7

jeffl wrote:

After the Daylight Savings Time change this morning, range statements are not being parsed correctly.

The code: […]

Worked just fine for the last few months. After the DST change, this error is generated:

[…]

This happens with versions 0.23.2 and 0.24.2

This also happens with 0.24.7

#7
Updated by James Turnbull over 2 years ago

  • Assignee deleted (Puppet Community)

#8
Updated by Evan Borgstrom almost 2 years ago

DST just happened again and I’m now seeing this issue.

(#507:1u:0r:0s) root@fatbox[/h/evan]: puppetd --verbose --onetime --no-daemonize
info: Retrieving plugin
info: Caching catalog for fatbox.fatboxes.com
info: Applying configuration version '1268580983'
err: Could not apply complete catalog: Incorrectly converted time: Sun Mar 14 03:00:21 -0400 2010: 3 vs 2 at /opt/puppet/modules/apt/manifests/init.pp:26
notice: Finished catalog run in 28.04 seconds

The manifest that’s generating this is

        schedule {
                "apt-clean":
                        period => daily,
                        range => "2 - 4",
                        repeat => 1;
        }

        exec {  
                "apt-clean":
                        schedule => "apt-clean",
                        command => "/usr/bin/apt-get autoclean",
                        require => Package["apt"];
        }

Both client and master are version 0.25.4 from the Debian backports repo.

Let me know what other info I can provide.

#9
Updated by Per Cederqvist 11 months ago

Today DST started here in Sweden, and my logs are full of the above message. At the very least, please change the log message by appending

If DST has just started or ended, this message is normal, and the situation will return to normal tomorrow.

so that users don’t have to be too concerned about this issue in the future.

Also available in: Atom PDF