The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #10614

Feature #8268: Basic Puppet agent support on Windows

Should not manage or source metadata from files on non-NTFS volumes on Windows

Added by Josh Cooper almost 3 years ago. Updated over 2 years ago.

Status:ClosedStart date:11/07/2011
Priority:NormalDue date:
Assignee:Josh Cooper% Done:

0%

Category:windows
Target version:2.7.8
Affected Puppet version:2.7.6 Branch:https://github.com/puppetlabs/puppet/pull/200
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

If a non-NTFS volume is mounted in Windows, we cannot get or set the owner, group or mode (DACL). In some cases, this can lead to a segfault due to interpreting the boolean return value incorrectly.

We should consider attempts to manage these files as invalid, and attempts to source metadata, e.g. uid, should return nil.


Related issues

Related to Puppet - Bug #10586: Windows puppet cannot source files remotely if owner and ... Closed 11/06/2011

History

#1 Updated by Josh Cooper almost 3 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to https://github.com/puppetlabs/puppet/pull/200

Previously puppet on Windows could segfault when managing files on non-NTFS volumes, such as a network share. There were also problems setting/clearing the readonly attribute, and issues interpreting BOOL return values.

These commits ensure that an error is raised when attempting to manage owner, group, and/or mode on non-NTFS volumes. It also provides default values when a file is sourced from a non-NTFS volume, for example, puppet resource file z:\

#2 Updated by Josh Cooper almost 3 years ago

Cygwin’s mount code solely looks at the FILE_PERSISTENT_ACLS flags to determine whether to attempt to get/set security descriptors, which is what we are doing. I also discovered that some ‘NTFS’ volumes do not support ACLs, e.g. NetApp, so I updated the error message to reflect that owner, etc can only be managed on filesystems that support Windows ACLs, such as NTFS.

#3 Updated by Jacob Helwig almost 3 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version changed from 2.7.x to 2.7.7

This has been merged into 2.7.x in commit:8c307e8801277e35a5d3a29bfb6df4c4faad80b0 and 2.7rc in commit:22b8722a25a61a4daea9e2aa174a87d8e07acc8c

#4 Updated by Matthaus Owens over 2 years ago

  • Status changed from Merged - Pending Release to Closed
  • Target version changed from 2.7.7 to 2.7.8

Released in 2.7.8rc1

Also available in: Atom PDF