Refactor #10309
Standardize fixture handling using Puppets methodology
| Status: | Closed | Start date: | 10/26/2011 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | testing | |||
| Target version: | 1.6.5 | |||
| Keywords: | fixtures, rspec | Affected Facter version: | ||
| Branch: | ||||
| Votes: | 0 |
Description
It was suggested by dpittman that we could use the fixture handling framework in Puppet:
https://github.com/puppetlabs/puppet/blob/master/spec/lib/puppet_spec/fixtures.rb
It would be nice to standardize the way we handle this – and also move our fixture data into the same place instead of having 2 locations.
Related issues
History
Updated by James Turnbull 7 months ago
- Status changed from Unreviewed to Accepted
Updated by Ken Barber 6 months ago
- Target version set to 1.6.x
Updated by Ken Barber 5 months ago
- Status changed from Accepted to In Topic Branch Pending Review
Merge request here:
https://github.com/puppetlabs/facter/pull/117
I took the opportunity to solve a few other cleanup problems as well, and introduced all the helpers from Puppet as we’ll need them for future patches anyway (such as extfacts and cache).
Updated by Jeff McCune 5 months ago
- Status changed from In Topic Branch Pending Review to Code Insufficient
Marking this as insufficient because Daniel and I need to align ourselves. I’m blocking merge currently because I don’t like the changes unrelated to Facter.
Comments are happening on the github pull request discussion.
Updated by Ken Barber 5 months ago
- Status changed from Code Insufficient to Merged - Pending Release
- Target version changed from 1.6.x to 1.6.5
Jeff merged in:
https://github.com/puppetlabs/facter/commit/ab19e29e6fecbc158dff4607ee6d0f882a41a190
Thanks.
Updated by Jeff McCune 5 months ago
Yep, thanks for updating the ticket. I was about to and got side tracked.
-Jeff
Updated by Matthaus Litteken 4 months ago
- Status changed from Merged - Pending Release to Closed
Released in Facter 1.6.5rc1