Puppet

This was against a recent update from the master branch.

I am running on Fedora 15 using the Ruby 1.8.7 that ships with it.

(had a little free time during lunch and this sounded interesting, FWIW)

Changing these tests from

@schedule.should be_match

to the uglier, but more explicit

@schedule.match?.should be_true

causes two (different than mentioned) tests to fail with wrong number of argument errors. While in irb initializing an instance of using the same steps in the tests I get all of the correct behavior (without args):

(note: it was about noon when I did this [and didn’t stub out Time in irb])

>> require 'puppet'

>> @sched = Puppet::Type.type(:schedule).new(:name => 'testing')

>> @sched[:range] = "10:59:50 - 10:59:55"
>> @sched.match?
=> false

>> @sched[:range] = "10:59:50 - 16:00:00"
>> @sched.match?
=> true

>> @sched[:range] = "13:59:50 - 16:00:00"
>> @sched.match?
=> false

I can confirm Justin’s findings.

If I take the original spec code from master (before the diffs I posted) and replace all instances of:

@schedule.should be_match

with

@schedule.match?.should be_true

or, if they have a parameter passed, replacing all instances of:

@schedule.should be_match(previous)

with:

@schedule.match?(previous).should be_true

Then I get one failure:

Failures:

  1) Puppet::Type::Schedule Puppet::Type::Schedule when matching ranges should match the upper array of ranges
     Failure/Error: @schedule.match?.should be_true
       expected false to be true
     # ./schedule_spec.rb:116

Finished in 0.5196 seconds
41 examples, 1 failure, 1 pending

I believe that this is correctly failing now. I could not get arrays of ranges to work in my prior interactive testing of schedules and this failure supports my experience that they do not function.

What should the next course of action be? I could submit a patch that would adjust all of the tests to the “@schedule.match?.should” style but I feel like leaving the “@schedule.should be_match” style unfixed would be asking for this to happen again and likely should be addressed by someone who knows rspec.

Puppet::Type has a method named should, from before we were using rspec. Unfortunately, if you write a test and it calls should on a type object the test will silently pass. We have an alias in place called must. You can replace should with must and get the correct behavior. It looks like all the schedule tests have this problem. I’ve fixed some of them in #10321, and I’m taking a look at the rest now.