Puppet » Facter

Ken,

I’m newish to git, and have no idea what a squash or rebase is. Sorry.

I’ve done the ‘git commit —amend’ and pushed it.

On Oct 22, 2011, at 7:19 AM, tickets@puppetlabs.com wrote:

Issue #10228 has been updated by Ken Barber. Status changed from Unreviewed to Requires CLA to be signed Hi Jeff,

Thanks for the submission :–).

Can you please sign the Contributor License Agreement? We’ll need that before we can accept the patch:

https://projects.puppetlabs.com/contributor_licenses/sign

Also – you might want to perform a squash on all commits (git rebase -i HEAD~2) … and add (#10228) at the beginning of the first commit message to reference this ticket (git commit —amend or you can do this with the rebase again). We can help with this if you need it. See the other commit messages for the format.

Thanks again :–).

ken.

Feature #10228: Add support for Ascendos to facter Author: Jeff Palmer Status: Requires CLA to be signed Priority: Normal Assignee: Category: library Target version: Keywords: RHEL, Ascendos Branch: Affected Facter version: I’ve submitted a pull request which allows facter to properly identify Ascendos (A new RHEL rebuild)

https://github.com/puppetlabs/facter/pull/84

You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account

I’m downloading the pre-alpha to check it out as well myself – for validation and curiosity reasons.

I just cracked open the ascendo-release SRPM to see what its doing in regards to the release file.

Looks like:

Ascendos release 6.0 (Nameless)

or for Beta:

Ascendos release 6.0beta1 (Nameless)

Is going to be the standard which should work fine for the code you’ve written – but a spec test like I mentioned to ensure this is validated properly should be added.

I wouldn’t mind a proper spec test for operatingsystemrelease_spec.rb which plucks out the number from a given string fixture like above, but this hasn’t been done for any RedHat variant yet. If you have the time that would be awesome but its a bigger problem that I believe is also covered by another ticket.

Ken,

I’ll try to catch you on IRC (I’m jpalmer) as there are a couple things I’d like to talk with you about (some related to this ticket, some not) and it’d probably just be simpler to talk there.

On Oct 23, 2011, at 12:23 PM, tickets@puppetlabs.com wrote:

Issue #10228 has been updated by Ken Barber. I’m downloading the pre-alpha to check it out as well myself – for validation and curiosity reasons.

I just cracked open the ascendo-release SRPM to see what its doing in regards to the release file.

Looks like:

Ascendos release 6.0 (Nameless) or for Beta:

Ascendos release 6.0beta1 (Nameless) Is going to be the standard which should work fine for the code you’ve written – but a spec test like I mentioned to ensure this is validated properly should be added.

I wouldn’t mind a proper spec test for operatingsystemrelease_spec.rb which plucks out the number from a given string fixture like above, but this hasn’t been done for any RedHat variant yet. If you have the time that would be awesome but its a bigger problem that I believe is also covered by another ticket.

Feature #10228: Add support for Ascendos to facter Author: Jeff Palmer Status: Tests Insufficient Priority: Normal Assignee: Jeff Palmer Category: library Target version: 1.6.3 Keywords: RHEL, Ascendos Branch: Affected Facter version: 1.6.2 I’ve submitted a pull request which allows facter to properly identify Ascendos (A new RHEL rebuild)

https://github.com/puppetlabs/facter/pull/84

You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account